-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move change password feature to a new tab #984
Comments
@mehreeee nice designs. |
Thank you Presh. Sorry that was a mistake. I've rectified it now |
This looks better. Good job! |
To add to what you guys have designed, on the change password page , I feel a forgot password link should be beneath the current password input field for users that can't remember their current password and wants to change it. When they click on it, they are redirected to a "Password Reset" page where they are prompted to enter their email address. After entering their email, they should receive a confirmation message indicating that a password reset link has been sent to their email. For the change password, I came up with suggestions that shows you the password strength as you type your new password, a real-time password strength indicator. This indicator displays the password's strength as users type their new password, providing immediate feedback on password security it also enhances user awareness and encourages the creation of stronger and more secure passwords. See screenshot below @srish |
Nice work @Dumzy006 funny I just thought about the same this morning. I've been iterating since last night. Well done. |
I love the design @Dumzy006 but can we have "Password too short" as indicators instead of weak, as it is more understandable for young users |
@aqsaaqeel what about a situation where the password is actually weak? I agree with re-wording for our young users but if it's weak, they should also know it's weak and have indicators for when their password is strong as @Dumzy006 has already shown. |
great job @Dumzy006 @DonPresh @mehreeee 👏🏻 |
Thank you @brrkrmn I don't think there's a need to put a link to change password in the edit profile page, rather it should be on the change password page. That's why I removed the 'current password' form field from the edit profile page on the last frame of my design here #984 (comment). |
oh got it @mehreeee thanks. Guess I missed this last frame, looks great |
Hi, @srish I want to note that, there should be some consistency throughout the site, that is if we iterate on the design/UX of the change password we should not forget at the level of Registration. Talking about the account settings:
Talking about password validation rules: |
Currently, we only want to show validation for when a password length > 8 to avoid complexity. So having one warning message should work. |
Nice work @roznaj. We shall consider a few of those to display, just to keep the design simpler |
Thanks everyone for your collaboration on this task! Let's go with @roznaj's first design here #984 (comment). The edit button would need to be removed from profile page accordingly. And, let's have "Settings" menu option right above logout option in the sidebar. Dev taking up ensure that design elements remain consistent with current components such as radius, color scheme, size, etc. |
Working on this. |
hey @aqsaaqeel, please look up at the linked PR. |
There is none |
@roznaj can you share the figma file of your design |
@NdibeRaymond raised an important point here #968 (comment) about why the change password feature should not be available on the edit profile page but on a different tab related to account settings.
So, this issue is about designing the new account settings tab. The "Account settings" menu option can be added on the user sidebar above the logout option. Upon clicking the account settings menu, it should open the change password form.
Ideally, we have a UX design for this feature first before the implementation step.
The text was updated successfully, but these errors were encountered: