Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: simplified chinese translation #177

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

aturret
Copy link
Contributor

@aturret aturret commented Jun 7, 2023

🔤 Polyglot PR

add a sweet (optional) meme

The website fully supports Simplified Chinese now.

Note: I use zh-CN as the corresponding i18n code but not zh. "Chinese" is actually a written/script system rather than a single language. When we talk about "Chinese" as a language without any specific limitations, it usually refers to Mandarin Chinese, which is the official language of the People's Republic of China(mainland China), the Republic of Singapore, and Taiwan. According to i18n locale codes, Mandarin Chinese language are divided into several subcategories for these different political entities. In a similar way to American English and British English, mainland China Mandarin (written in Simplified Chinese) and Taiwanese Mandarin (written in Traditional Chinese) are the two primary variants of Mandarin Chinese, and there are slight differences in vocabulary between them. Therefore, I cannot give a perfectly accurate zh-TW translation by simply transforming the simplified Chinese characters into traditional ones. As a native Mainlander, I think my personal translation can only represent people who originate from mainland China.

Type of change

  • Docs update (changes to the readme or a site page, no code changes)
  • Ops wrangling (automation or test improvements)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Sweet release (needs a lot of work and effort)
  • Something else (explain please)

Checklists

  • If modifying code, at least one test has been added to the suite

@@ -34,6 +34,7 @@ hello:
nl: Hallo!
he: "שלום!"
ko: 안녕하세요!
zh-CN: 你好!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I use zh-CN as the corresponding i18n code but not zh

That's totally fine and correct here. Many other countries will use a country-specific designation as part of their browser configuration (for example Portuguese in portugal and brazil are considered different as well and those countries will favor pt-PT or pt-BR).

worth calling out the in readme for users of these language codes.

@untra untra merged commit 0b34dac into untra:master Jun 8, 2023
untra added a commit that referenced this pull request Jun 9, 2023
…lation

Feature: simplified chinese translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants