Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot config reloads do not consider actor custom parameters #50

Open
pct-cclausen opened this issue Dec 6, 2020 · 7 comments
Open

hot config reloads do not consider actor custom parameters #50

pct-cclausen opened this issue Dec 6, 2020 · 7 comments
Assignees
Labels

Comments

@pct-cclausen
Copy link

  1. Initialize a forked (maybe also in-memory?) actor with custom parameters. I primarily use this to pass in some other ActorRefs.
  2. The actor reads from getCustomParameters() in the initialize method, everything works.
  3. Change the configuration of that actor.
  4. The actor gets destroyed and recreated, but getCustomParameters() now is undefined. debug mode shows the custom parameters are just gone from the create-actor message used internally.

I guess the hot reloading code is just missing this behavior entirely?

@weekens
Copy link
Contributor

weekens commented Dec 7, 2020

Hi @pct-cclausen ! Thanks for your report! Will try to fix that in nearest time!

@weekens weekens self-assigned this Dec 7, 2020
@weekens weekens added the bug label Dec 15, 2020
weekens added a commit that referenced this issue Dec 15, 2020
@weekens
Copy link
Contributor

weekens commented Dec 15, 2020

Fixing this in #57.

@weekens
Copy link
Contributor

weekens commented Dec 15, 2020

Fix released in version 2.1.2. Thanks again for the report!

@weekens weekens closed this as completed Dec 15, 2020
@pct-cclausen
Copy link
Author

Nice, thanks for the fix. Works like a charm :)

@pct-cclausen
Copy link
Author

Actually, I believe this seems still to be broken in case of threaded actors.
Playing around, it works for forked actors now, but I still get errors when I used threaded instead.

@weekens weekens reopened this Dec 16, 2020
@weekens
Copy link
Contributor

weekens commented Dec 16, 2020

Okay, I'm reopening it then. Will check.

@weekens
Copy link
Contributor

weekens commented Jan 10, 2021

@pct-cclausen This time, I'm afraid, the problem does not reproduce that easy. I've added the test case for threaded actor (see hot-config-fix-2 branch), and it works fine. What kind of errors do you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants