-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging the Development Branch from Our Fork #148
Conversation
Instructor preference
Revert "Instructor preference"
…erence Revert "Revert "Instructor preference""
pull from master
2. Instructor view now only shows the courses that are relevant(courses that will be taught by the instructor)
Nice, just adding here what you @edward0414 @jsyoon01 already know, Fixes the top bullet in #143, though the modal doesn't come up and my browser window freezes when clicking the last name. I haven't been able to spot the reason in the code, yet. Fixes the fourth bullet in #144 for the unassigned-table. Would it be possible to also fix the alignment for the assigned-table? Fixes #145. |
@jsyoon01, what do you think? I think this merge should be revered for two reasons: |
@nigef I agree. I merged the branch at first because I thought it is just a small branch for Sungyoon and I. Now we figuring out the workflow and knowing that it's main branch for this summer group to push to, it is a good idea to not merge the PR until everything is working. |
Merging the instructor-switch feature and instructor landing page feature into a "development" branch