Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #145

Merged
merged 21 commits into from
Apr 11, 2023
Merged

Notifications #145

merged 21 commits into from
Apr 11, 2023

Conversation

ouwou
Copy link
Member

@ouwou ouwou commented Mar 12, 2023

closes #94

this introduces desktop notifications. currently only on mac/linux/whatever supports org.freedesktop.Notifications

miniaudio will also be an optional dependency for notification sounds (which im using as opposed to something like libcanberra because ill be using miniaudio anyways in the voice implementation)

some things remaining:

  • general settings for notifications including option to turn them off altogether
  • cleaning up markup because notification servers like to parse them
  • notification withdraw
  • configure channel notification settings from within the client itself (might not do this)
  • handle potential weird edge cases (i.e. end_time)
  • handle role mentions properly
  • check if im doing action target values properly
  • other stuff that i am forgetting

@ouwou ouwou merged commit 44ab35d into master Apr 11, 2023
@ouwou ouwou deleted the notifications branch June 3, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need notifications
1 participant