-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop source ANALYTICS
#505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iliascholl-up42 :)
left a small suggestion.
@@ -141,7 +141,7 @@ def get_assets( | |||
producer_names: Search for assets from any of the provided producers. | |||
tags: Search for assets with any of the provided tags. | |||
sources: Search for assets from any of the provided sources.\ | |||
The allowed values: `"ARCHIVE"`, `"TASKING"`, `"ANALYTICS"`, `"USER"`. | |||
The allowed values: `"ARCHIVE"`, `"TASKING"`, `"USER"`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowed values: `"ARCHIVE"`, `"TASKING"`, `"USER"`. | |
The allowed values: `"ARCHIVE"`, `"TASKING"`, `"PROCESSING"`, `"USER"`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, wow! I failed to see that there is no PROCESSING
source in that list.
Still, we shouldn't be adding it here since the API will not return any assets with the PROCESSING
source on the list assets endpoint
@iliascholl-up42 do not merge yet! |
pyproject.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "up42-py" | |||
version = "0.33.1" | |||
version = "0.33.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliascholl-up42
I completely forgot.
We don't need to bump version since we are not releasing a new version. We can release it with a bunch of other PRs related to v2 endpoint migration.
Or, do you want to release a new SDK version for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we don't need to release this one, I think. In the worst case, the customer will try to get assets for source ANALYTICS
and encounter a bad request. The chance is rather low, I think.
I'll revert the change of the version then
e35f0cf
to
84c8ee9
Compare
84c8ee9
to
d0a6cb9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This depends on https://github.com/up42/asset-service/pull/558
Items:
For release: