Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docker image for publishing #516

Merged
merged 1 commit into from
Dec 14, 2023
Merged

update docker image for publishing #516

merged 1 commit into from
Dec 14, 2023

Conversation

seedlit
Copy link
Contributor

@seedlit seedlit commented Dec 14, 2023

Scope: Use cimg/python3.11 as base docker image for publishing to pypi.

Items:

  • Ran test & live-tests
  • Implemented (new) unit tests
  • Removed credentials
  • Removed argument pointing to staging
  • Updated documentation

For release:

  • Bumped version
  • Added changelog
  • Updated announcement banner

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

andher1802
andher1802 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@andher1802 andher1802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seedlit seedlit merged commit 5172f8f into master Dec 14, 2023
3 checks passed
@seedlit seedlit deleted the fix_publishing_to_pypi branch December 14, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andher1802 andher1802 andher1802 approved these changes

@javidq javidq Awaiting requested review from javidq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seedlit @andher1802