Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT4219 bugfix display name tasking orders #540

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

andher1802
Copy link
Contributor

(insert scope and description here)

Items:

  • Ran test & live-tests
  • Implemented (new) unit tests
  • Removed credentials
  • Removed argument pointing to staging
  • Updated documentation

For release:

  • Bumped version
  • Added changelog
  • Updated announcement banner

@andher1802 andher1802 marked this pull request as ready for review February 19, 2024 08:29
@@ -18,7 +18,9 @@ def _translate_construct_parameters(order_parameters):
order_parameters_v2 = deepcopy(order_parameters)
params = order_parameters_v2["params"]
data_product_id = order_parameters_v2["dataProduct"]
if not params.get("displayName", None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified to

default_name = f"{data_product_id} order"
order_parameters_v2["displayName"] = params.get("displayName", default_name)

Copy link

sonarcloud bot commented Feb 19, 2024

@andher1802 andher1802 merged commit 265bc54 into master Feb 19, 2024
3 checks passed
@andher1802 andher1802 deleted the AT4219_Bugfix_DisplayNameTaskingOrders branch February 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants