-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AT-4866 Account token retrieval #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (looked over the surface).
Please pull changes from master, and then I can approve
up42/http/oauth.py
Outdated
self.token_url = token_settings.token_url | ||
self.duration = token_settings.duration | ||
self.timeout = token_settings.timeout | ||
self.adapter = create_adapter(include_post=True) | ||
self.retrieve = retrieve | ||
self._token = self._fetch_token() | ||
|
||
def __call__(self, request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to this PR, but consider adding type hints
Quality Gate passedIssues Measures |
Generalize new auth stack to include account authentication in addition to project authentication
Items:
For release: