Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT-4866 Account token retrieval #553

Merged
merged 6 commits into from
Mar 7, 2024
Merged

AT-4866 Account token retrieval #553

merged 6 commits into from
Mar 7, 2024

Conversation

javidq
Copy link
Contributor

@javidq javidq commented Mar 6, 2024

Generalize new auth stack to include account authentication in addition to project authentication

Items:

  • Ran test & live-tests
  • Implemented (new) unit tests
  • Removed credentials
  • Removed argument pointing to staging
  • Updated documentation

For release:

  • Bumped version
  • Added changelog
  • Updated announcement banner

@javidq javidq marked this pull request as ready for review March 6, 2024 17:02
Copy link
Contributor

@seedlit seedlit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (looked over the surface).
Please pull changes from master, and then I can approve

self.token_url = token_settings.token_url
self.duration = token_settings.duration
self.timeout = token_settings.timeout
self.adapter = create_adapter(include_post=True)
self.retrieve = retrieve
self._token = self._fetch_token()

def __call__(self, request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR, but consider adding type hints

Copy link

sonarcloud bot commented Mar 7, 2024

@javidq javidq merged commit b33557c into master Mar 7, 2024
3 checks passed
@javidq javidq deleted the AT-4866-account-auth branch March 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants