-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AT-3970] enable pylint for initialization #561
Conversation
Co-authored-by: Daria Lutchenko <102282963+dustgalactic@users.noreply.github.com>
tests/test_initialization.py
Outdated
|
||
with pytest.raises(RuntimeError): | ||
up42.initialize_project() | ||
up42.initialization.initialize_project() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we actually need to check that the signature used by users works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the same below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point.
If I remove .initialization
, mypy complains with error: Module has no attribute "initialize_project"
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed below
tests/test_initialization.py
Outdated
with pytest.raises(RuntimeError): | ||
up42.initialize_asset(asset_id=ASSET_ID) | ||
up42.initialization.initialize_asset(asset_id=constants.ASSET_ID) | ||
|
||
|
||
# pylint: disable=unused-argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop this
tests/test_initialization.py
Outdated
|
||
with pytest.raises(RuntimeError): | ||
up42.initialize_project() | ||
up42.initialization.initialize_project() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed below
Quality Gate passedIssues Measures |
Jira ticket here.
Scope: enable pylint for all initialization files
Items:
For release: