-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AT-4086] Enable linting for asset modules #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments
CHANGELOG.md
Outdated
@@ -30,6 +30,14 @@ You can check your current version with the following command: | |||
|
|||
For more information, see [UP42 Python package description](https://pypi.org/project/up42-py/). | |||
|
|||
## 0.37.0a11 | |||
|
|||
**March 13, 2024** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to update the date.
@@ -80,27 +79,20 @@ def test_asset_update_metadata(asset_mock): | |||
assert updated_info["tags"] == ["othertag1", "othertag2"] | |||
|
|||
|
|||
def test_asset_get_download_url(assets_fixture): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we removing this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It's not a public method
- It is used by asset::download (covered by tests) and asset::get_stac_asset_url (not covered anyway)
Quality Gate passedIssues Measures |
Enable linting for asset + coverage + fixtures, asset_searcher and http_adapter.
Items:
For release: