-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AT-4915] Dependency injection and test coverage for auth.py #575
Conversation
@@ -503,7 +503,7 @@ def download_quicklooks( | |||
with open(out_path, "wb") as dst: | |||
for chunk in response: | |||
dst.write(chunk) | |||
except ValueError: | |||
except IOError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was getting before ValueError due to the bug fixed in auth.py in this PR - err.response.json() was failing due to invalid response content
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked over the surface.
LGTM!
Injection of functional dependencies and test coverage for auth.py
Items:
For release: