Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT4944 Updating deprecation dates #578

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

andher1802
Copy link
Contributor

Updating the deprecation dates for Projects, Workflows, and Jobs

Items:

For release:

  • Bumped version
  • Added changelog
  • Updated announcement banner

Copy link
Contributor

@seedlit seedlit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

@@ -20,6 +20,8 @@

logger = utils.get_logger(__name__, level=logging.INFO)

deprecation_date = "after May 15th, 2024, and will be replaced by new processing functionalities."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
since this is a global constant, consider using all caps.
for eg.: DEPRECATION_MESSAGE

Copy link

sonarcloud bot commented Apr 3, 2024

@andher1802 andher1802 merged commit 7bb712e into master Apr 3, 2024
6 checks passed
@andher1802 andher1802 deleted the AT4944-UpdateDeprecationMessages branch April 3, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants