Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT-5138] Drop get blocks, get block details and block coverage #593

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[PT-5138] Drop get blocks, get block details and block coverage #593

merged 2 commits into from
Apr 17, 2024

Conversation

javidq
Copy link
Contributor

@javidq javidq commented Apr 16, 2024 •
edited
Loading

Dropped get_blocks, get_block_details and get_block_coverage from main.py

Items:

For release:

  • Bumped version
  • Added changelog

@javidq javidq marked this pull request as ready for review April 16, 2024 15:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

andher1802
andher1802 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@andher1802 andher1802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javidq javidq merged commit d64636b into master Apr 17, 2024
6 checks passed
@javidq javidq deleted the PT-5138-drop-blocks-listing branch April 17, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andher1802 andher1802 andher1802 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javidq @andher1802