Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmark_wpt function so that it returns an error code #30

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix benchmark_wpt function so that it returns an error code #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions test/bench-url.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ int benchmark_txt(const char* file_name, uint64_t min_iters) {
// -----------------------------------------------------------------------------
// Read samples from urltestdata.json and benchmark

void benchmark_wpt(const char* file_name, uint64_t min_iters) {
int benchmark_wpt(const char* file_name, uint64_t min_iters) {
std::vector<std::pair<std::string, std::string>> url_samples;

// Load URL samples
Expand All @@ -75,8 +75,9 @@ void benchmark_wpt(const char* file_name, uint64_t min_iters) {
return true;
} };

if (!json_util::load_file(context, file_name, "Load URL samples from"))
return;
const int err = json_util::load_file(context, file_name, "Load URL samples from");
if (err != 0)
return err;

// Run benchmark

Expand All @@ -96,6 +97,8 @@ void benchmark_wpt(const char* file_name, uint64_t min_iters) {
ankerl::nanobench::doNotOptimizeAway(url);
}
});

return 0;
}

// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -123,13 +126,11 @@ int main(int argc, const char* argv[])
: min_iters_def;

if (file_name.extension() == ".json") {
benchmark_wpt(file_name.string().c_str(), min_iters);
return benchmark_wpt(file_name.string().c_str(), min_iters);
} else if (file_name.extension() == ".txt") {
benchmark_txt(file_name.string().c_str(), min_iters);
} else {
std::cerr << "File containing URLs should have .json or .txt extension.\n";
return 1;
return benchmark_txt(file_name.string().c_str(), min_iters);
}

return 0;
std::cerr << "File containing URLs should have .json or .txt extension.\n";
return 1;
}
Loading