Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ICU library bundled with Windows #49

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Add support for ICU library bundled with Windows #49

merged 3 commits into from
Jul 8, 2024

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented Jul 7, 2024

This adds the cmake option variable UPA_USE_WINDOWS_ICU and a preprocessor macro of the same name for this purpose:

  1. For cmake CLI add the option -DUPA_USE_WINDOWS_ICU=ON
  2. Or define the preprocessor macro UPA_USE_WINDOWS_ICU = 1 if you are using amalgamated sources

The UPA_USE_WINDOWS_ICU cmake option variable is added for this purpose
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (c9b7de4) to head (b71aca6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          16       16           
  Lines        2333     2333           
  Branches      387      387           
=======================================
  Hits         2325     2325           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisev rmisev merged commit 45cfe00 into main Jul 8, 2024
24 checks passed
@rmisev rmisev deleted the win-icu branch July 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant