Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lecturer all courses #376

Merged
merged 12 commits into from
Aug 20, 2020
Merged

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Aug 19, 2020

Description

Implements issue #375

Reason for this PR

  • The lecturer might want to have an overview of all existing courses

Changes in this PR

  • add a new route
  • routing to the lecturer course list now provides a prop to determine whether all courses or just own courses should be shown
  • component refreshes if prop changes
  • when showing all courses, the edit button will be shown iff its your own course

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • deployed development build

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Aug 19, 2020
@tobias-wiese tobias-wiese marked this pull request as draft August 19, 2020 14:39
@tobias-wiese tobias-wiese marked this pull request as ready for review August 19, 2020 16:03
src/components/CourseList.vue Outdated Show resolved Hide resolved
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
@tobias-wiese tobias-wiese merged commit f17f540 into develop Aug 20, 2020
@tobias-wiese tobias-wiese deleted the feature/lecturer_all_courses branch August 20, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants