Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/reset_address_input_on_cancel #381

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Aug 20, 2020

Description

Fixes issue #379

Reason for this PR

  • see bugreport

Changes in this PR

  • do a deep copy of the prop object to avoid call by reference

Type of change (remove all that don't apply)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (done on test catch up branch)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese changed the title fix the bug (caused by call by reference of Object prop) bugfix/reset_address_input_on_cancel Aug 20, 2020
@tobias-wiese tobias-wiese merged commit 7f2487e into develop Aug 21, 2020
@tobias-wiese tobias-wiese deleted the bugfix/reset_address_input_on_cancel branch August 21, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants