Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navbar Clickable Area on Mobile and Desktop #513

Merged
merged 18 commits into from
Sep 26, 2020
Merged

Conversation

theovier
Copy link
Collaborator

@theovier theovier commented Sep 23, 2020

Description

Fixes issue #480

Reason for this PR

  • Merging the JWT branch into develop resulted in a not correctly behaving navigation. Also the mobile clickarea was not as polished as the desktop clickarea.

Changes in this PR

  • Adjust the mobile navbar to be clickable when indicated. Fix a problem with the desktop navbar that it would only register hits on the actual name of the item.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend:

    • Development build
  • Backend:

    • deployed production build

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@theovier theovier self-assigned this Sep 23, 2020
@theovier theovier changed the title [WIP] Bugfix/navbar Fix Navbar Clickable Area on Mobile and Desktop Sep 24, 2020
@theovier theovier added responsive visual Something visual in the user interface vue labels Sep 24, 2020
@theovier theovier linked an issue Sep 24, 2020 that may be closed by this pull request
@theovier theovier requested review from bastihav and tobias-wiese and removed request for bastihav September 24, 2020 07:56
CHANGELOG.md Outdated Show resolved Hide resolved
@theovier theovier merged commit 8cf54ae into develop Sep 26, 2020
@theovier theovier deleted the bugfix/navbar branch September 26, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
responsive visual Something visual in the user interface vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons of mobile navbar are smaller than "clickable" area
2 participants