Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused placeholder menu items from student desktop navbar #537

Closed
wants to merge 5 commits into from

Conversation

theovier
Copy link
Collaborator

@theovier theovier commented Sep 28, 2020

Description

Reason for this PR

  • non-working menu stubs should not be included in an MVP

Changes in this PR

  • remove non-working menu stubs from the student's desktop navbar. The student's courses menu now only has 1 column as there is only 1 item in it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend:

    • Development build
  • Backend:

    • No backend needed to test this

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@theovier theovier changed the title [WIP] Remove unused placeholder menu items from student desktop navbar Remove unused placeholder menu items from student desktop navbar Sep 28, 2020
Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could additionally delete the course menu footer, as it is not needed in our application atm

CHANGELOG.md Outdated Show resolved Hide resolved
theovier and others added 2 commits September 28, 2020 16:00
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
@theovier
Copy link
Collaborator Author

We could additionally delete the course menu footer, as it is not needed in our application atm

done.

@theovier theovier closed this Sep 30, 2020
@theovier theovier deleted the bugfix/cleanup_student_navbar branch September 30, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove menu item stubs from student's (desktop) navbar
2 participants