Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/matriculation validation #543

Merged
merged 16 commits into from
Sep 29, 2020
Merged

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Sep 28, 2020


Remove this, if this PR is not to main!

Version to release: v0.9.0-hotfix.1

Merging this pull request will automatically:

  • create a tag using the version in our package.json
  • publish a release using this tag, referencing the CHANGELOG.md
  • publish the release on dockerhub using the version of our package.json

Please fill out the following checklist:

  • The version of the package.json is different to every other tag in this repository
  • The CHANGELOG.md contains all changes (bugfixes, features, dependency updates, ...) for this release

Description

Reason for this PR

Changes in this PR

  • adapt error bag to enable searching for substrings (as we get errors in form of e.g. matriculations[0].semesters[0])
  • remove v-modelled immatriculationChanged variable
  • change desired error type to HLUnprocessableEntity

Type of change (remove all that don't apply)

  • Hotfix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed development build

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the package.json version if this is a new release candidate
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added bug Something isn't working vue labels Sep 28, 2020
@tobias-wiese tobias-wiese merged commit d40707a into main Sep 29, 2020
@tobias-wiese tobias-wiese deleted the hotfix/matriculation_validation branch September 29, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants