Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal signing #642

Merged
merged 23 commits into from
Nov 5, 2020
Merged

Proposal signing #642

merged 23 commits into from
Nov 5, 2020

Conversation

bastihav
Copy link
Collaborator

@bastihav bastihav commented Oct 26, 2020

Description

Draft until certificates is merged, as this already uses certificate's implementation

Implements part of #594

Reason for this PR

  • We want to sign proposals in the frontend

Changes in this PR

  • implement signing and verification of signatures for proposals

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Manually tested with Matthias.

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows
  • Browser: Chrome

Checklist: (remove all that don't apply)

  • I added corresponding unit tests (if API code)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@bastihav bastihav marked this pull request as ready for review November 3, 2020 09:10
@bastihav bastihav added the vue label Nov 3, 2020
Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProposalValidator.ts Outdated Show resolved Hide resolved
src/api/helpers/ProtobuffDecoding.ts Outdated Show resolved Hide resolved
src/use/crypto/signing.ts Show resolved Hide resolved
src/use/crypto/signing.ts Outdated Show resolved Hide resolved
tests/unit/proposalSigning.spec.ts Show resolved Hide resolved
bastihav and others added 9 commits November 5, 2020 08:37
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: Theo Harkenbusch <Theo@Harkenbusch.com>
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
@bastihav bastihav merged commit 6cbb3dd into develop Nov 5, 2020
@bastihav bastihav deleted the feature/transactions branch November 5, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants