-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal signing #642
Merged
Merged
Proposal signing #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wiese
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
theovier
approved these changes
Nov 4, 2020
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: tobias-wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: Theo Harkenbusch <Theo@Harkenbusch.com>
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft until certificates is merged, as this already uses certificate's implementation
Implements part of #594
Reason for this PR
Changes in this PR
Type of change (remove all that don't apply)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Manually tested with Matthias.
Test Configuration:
Checklist: (remove all that don't apply)