Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examination Regulation API #706

Merged
merged 71 commits into from
Nov 23, 2020
Merged

Examination Regulation API #706

merged 71 commits into from
Nov 23, 2020

Conversation

bastihav
Copy link
Collaborator

@bastihav bastihav commented Nov 17, 2020

Description

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Chrome

  • Frontend: (remove all that don't apply)

    • Development build
    • Production build
    • Dockerized production build
  • Backend: (remove all that don't apply)

    • deployed development build
    • deployed experimental build

Checklist: (remove all that don't apply)

  • I added corresponding unit tests (if API code)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the package.json version if this is a new release candidate (remove is it is not)
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)
  • I have reverted commit 6797332 , ee05f78 and d93a7d8 (for testing against experimental cluster)

bastihav and others added 30 commits October 29, 2020 12:15
atm it is the normal course list wihtout any exregs
there's a visual bug still when using editMode
Co-authored-by: Paul Kramer <pkramer1@mail.uni-paderborn.de>
Co-authored-by: Paul Kramer <pkramer1@mail.uni-paderborn.de>
this has to be used on each module update. The old way added all ExRegs to the form, even if their modules were not selected
Co-authored-by: Theo Harkenbusch <theo@harkenbusch.com>
@tobias-wiese tobias-wiese self-assigned this Nov 20, 2020
@bastihav bastihav merged commit 4f3c670 into develop Nov 23, 2020
@bastihav bastihav deleted the feature/exam-reg branch November 23, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants