Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Vuex store on logout #732

Merged
merged 15 commits into from
Nov 25, 2020
Merged

Reset Vuex store on logout #732

merged 15 commits into from
Nov 25, 2020

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Nov 23, 2020

Description

Reason for this PR

  • The store was not resetted after logout, hence e.g. the certificate was not deleted

Changes in this PR

  • add a default state
  • add a mutation RESET_STATE that assign the default state to the store state
  • commit the new mutation on logout

Type of change (remove all that don't apply)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Firefox

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • deployed development build

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added bug Something isn't working vue labels Nov 23, 2020
@tobias-wiese tobias-wiese changed the title Bugfix/reset store Reset Vuex store on logout Nov 23, 2020
@tobias-wiese tobias-wiese merged commit 89db49e into develop Nov 25, 2020
@tobias-wiese tobias-wiese deleted the bugfix/reset_store branch November 25, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate is only shown after clicking of create, even if one exists
2 participants