Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReDesign #782

Merged
merged 410 commits into from
Feb 1, 2021
Merged

ReDesign #782

merged 410 commits into from
Feb 1, 2021

Conversation

theovier
Copy link
Collaborator

@theovier theovier commented Jan 3, 2021

Full ReDesign Front-End

As we changed our design, we had to touch basically every file that may be displayed to a user, which results in a lot of files changed. We realise that this is a major pain in the a** to review, so we tried to adjust every e2e test so that no functionality would be lost during the merge.

Changes in this PR

  • new styles
  • easier to use components, especially for sections, which will make future development work much smoother (see BaseSection, SectionHeader, ButtonSection).
  • restyled every view and component to use these components and new styles
  • dark-mode 🥳

Dependency update

  • remove Tailwind 1.X
  • add Tailwind 2.X
  • add HeadlessUI

Type of change

  • Refactoring
  • New feature
  • Testing
  • This change requires a documentation update (README, e.g. deployment changes)
    • I added the documentation

TODOs

As we didn't quite finish everything yet, there are some small pieces left that need to be adjusted.

  • Style Decrypt-Modal
  • Style Delete-Course-Modal
  • Style Delete-Account-Modal
  • Remove Enter-Password-Modal
  • Style Immatriculation-Modal
  • Style Login-Modal
  • Style Module-Information-Section in Edit/Create Course
  • Style Immatriculation Section in Account Edit
  • Add Hyperledger-Version to About-Page (maybe required API-Change, needs to be discucssed beforehand)
  • Darkmode for SearchableSelects
  • Remove Old CSS Styles once every component has been replaced
  • Remove playground views
  • Tags Dark-Mode
  • Style Course Info Page
  • Style Immatriculation History
  • Style Decrypt Key Modal

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR

this-kramer and others added 30 commits December 30, 2020 13:59
Copy link
Collaborator

@bastihav bastihav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buggy workflow:
upload picture (which has a correct size)
delete picture
upload picture again (nothing happens here)

src/components/common/dev/about/ServiceStatusSection.vue Outdated Show resolved Hide resolved
src/components/common/dev/about/ServiceStatusCard.vue Outdated Show resolved Hide resolved
this-kramer and others added 2 commits February 1, 2021 11:34
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Copy link
Contributor

@tobias-wiese tobias-wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Navbar menu icons for "Enroll in courses" and "My courses" are switched
  • Course description textarea in course form could need a placeholder "(optional)"
  • non editable courses still have a cursor-pointer on their course title, but you cannot click it
  • initial values within profile not set after successfull update. Reproduce: append something to city, click update. Then update button is still enabled and becomes disabled when removing the appended string. After refresh, the change is there though
  • change password fields in settings should have placeholders (now its kinda empty)

src/components/course/edit/sections/InfoSection.vue Outdated Show resolved Hide resolved
src/components/course/edit/sections/LecturerSection.vue Outdated Show resolved Hide resolved
src/components/course/list/student/CourseList.vue Outdated Show resolved Hide resolved
src/use/helpers/Toasts.ts Outdated Show resolved Hide resolved
@this-kramer
Copy link
Contributor

this-kramer commented Feb 1, 2021

buggy workflow:
upload picture (which has a correct size)
delete picture
upload picture again (nothing happens here)

Added issue since also present on develop -> #820

@this-kramer this-kramer self-requested a review February 1, 2021 16:59
@this-kramer this-kramer merged commit 3df5bc6 into develop Feb 1, 2021
@tobias-wiese tobias-wiese deleted the feature/tailwind branch February 26, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion help wanted Extra attention is needed refactor responsive visual Something visual in the user interface vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants