-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReDesign #782
ReDesign #782
Conversation
…into feature/tailwind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buggy workflow:
upload picture (which has a correct size)
delete picture
upload picture again (nothing happens here)
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Navbar menu icons for "Enroll in courses" and "My courses" are switched
- Course description textarea in course form could need a placeholder "(optional)"
- non editable courses still have a
cursor-pointer
on their course title, but you cannot click it - initial values within profile not set after successfull update. Reproduce: append something to city, click update. Then update button is still enabled and becomes disabled when removing the appended string. After refresh, the change is there though
- change password fields in settings should have placeholders (now its kinda empty)
Added issue since also present on develop -> #820 |
Co-authored-by: Tobias Wiese <63233799+tobias-wiese@users.noreply.github.com>
Co-authored-by: Tobias Wiese <63233799+tobias-wiese@users.noreply.github.com>
Full ReDesign Front-End
As we changed our design, we had to touch basically every file that may be displayed to a user, which results in a lot of files changed. We realise that this is a major pain in the a** to review, so we tried to adjust every e2e test so that no functionality would be lost during the merge.
Changes in this PR
Dependency update
Type of change
TODOs
As we didn't quite finish everything yet, there are some small pieces left that need to be adjusted.
Checklist: