Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change display of the timestamp in the request data section #799

Merged
merged 6 commits into from
Feb 17, 2021
Merged

change display of the timestamp in the request data section #799

merged 6 commits into from
Feb 17, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Jan 19, 2021 •
edited
Loading

Description

  • Change date display format

Reasons for this PR

As our application is in english language, we should not use the toLocaleString method on the date as this could be inconsistent.

Changes in this PR

  • Change format from DD.MM.YYYY, 24:59:59 to shortDay, DD/MM/YYYY, 24:59 according to the en-GB format

Before:
grafik

After:
grafik

Type of change (remove all that don't apply)

  • Refactoring

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese merged commit 0376062 into develop Feb 17, 2021
@tobias-wiese tobias-wiese deleted the refactor/date_format branch February 17, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theovier theovier theovier approved these changes

Assignees
No one assigned
Labels
refactor vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobias-wiese @theovier