-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam UI #844
Merged
Merged
Exam UI #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastihav
requested changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
maybe an indication, that exams are finished and(/not yet) graded on the "Your Exams" view of the lecturer would be cool
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
tobias-wiese
requested review from
bastihav and
theovier
and removed request for
this-kramer
February 26, 2021 11:23
nklsd
reviewed
Feb 27, 2021
bastihav
approved these changes
Mar 1, 2021
nklsd
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the UI for exam management (create, view, admit/drop, grade, view grades)
Reason for this PR
Changes in this PR
ISODatePicker
that transforms select inputs for Day, Month, Year, Hour and Minutes to a valid ISO date stringType of change (remove all that don't apply)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
OS: Windows Mac Linux
Browser: Firefox Chrome Safari Chromium
Frontend: (remove all that don't apply)
Backend: (remove all that don't apply)
Checklist: (remove all that don't apply)
Notes:
executeTransaction
abstraction for handling transactions, I was not able to implement proper error handling. The error-labels and bags are there, but the bag does not get filled via the API.Screenshots
Lecturer Exam List
Create Exam View
View and Grade Exam View (Lecturer) with one admitted student
Create Exam Operation (Admin)
Student Exam List
Student Exam Performances View