Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam UI #844

Merged
merged 103 commits into from
Mar 3, 2021
Merged

Exam UI #844

merged 103 commits into from
Mar 3, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Feb 8, 2021

Description

Adds the UI for exam management (create, view, admit/drop, grade, view grades)

Reason for this PR

Changes in this PR

  • add list containing all exams of the lecturer
  • add createViewExam page for the lecturer where he can create a new exam or view the config of a given one
  • add list containig all admittable exams for the student
  • add buttons for admitting and dropping exams
  • add option for lecturer to grade exams
  • add a exam performances view
  • add a new component ISODatePicker that transforms select inputs for Day, Month, Year, Hour and Minutes to a valid ISO date string

Type of change (remove all that don't apply)

  • New feature

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed experimental build

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Notes:

  • I did not implement proper E2E here, as we will not be able to test the whole workflow from creating a course to displaying an exam grade for the student.
  • Due to the newly implemented executeTransaction abstraction for handling transactions, I was not able to implement proper error handling. The error-labels and bags are there, but the bag does not get filled via the API.
  • The API has been reviewed by me before merging it on this branch

Screenshots

Lecturer Exam List
grafik

Create Exam View
grafik

View and Grade Exam View (Lecturer) with one admitted student
grafik

Create Exam Operation (Admin)
grafik

Student Exam List
grafik

Student Exam Performances View
grafik

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Feb 8, 2021
@tobias-wiese tobias-wiese changed the title Lecturer create exam UI Exam UI Feb 8, 2021
@tobias-wiese tobias-wiese marked this pull request as ready for review February 24, 2021 12:09
Copy link
Collaborator

@bastihav bastihav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

maybe an indication, that exams are finished and(/not yet) graded on the "Your Exams" view of the lecturer would be cool

src/components/common/TimePicker.vue Outdated Show resolved Hide resolved
src/components/exam/Grades.ts Outdated Show resolved Hide resolved
src/components/exam/list/ExamRow.vue Outdated Show resolved Hide resolved
src/use/helpers/NumberToZeroPaddedString.ts Show resolved Hide resolved
src/use/xlsx/GradingTable.ts Outdated Show resolved Hide resolved
src/views/shared/CreateViewExamForm.vue Outdated Show resolved Hide resolved
@tobias-wiese tobias-wiese requested review from bastihav and theovier and removed request for this-kramer February 26, 2021 11:23
@tobias-wiese tobias-wiese requested review from nklsd and removed request for theovier February 26, 2021 13:35
src/entities/ExamEntity.ts Show resolved Hide resolved
tests/e2e/CreateExam.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nklsd nklsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@tobias-wiese tobias-wiese merged commit e1d82c4 into develop Mar 3, 2021
@tobias-wiese tobias-wiese deleted the feature/create_exam_ui branch March 3, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment