Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix exam form #878

Merged
merged 6 commits into from
Mar 8, 2021
Merged

Bugfix exam form #878

merged 6 commits into from
Mar 8, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Mar 3, 2021

Reason for this PR

  • Date object was parsed in a wrong way
  • resetting course and module did not work on failure
  • exam list crashed when student fetched exams but no matching courses

Changes in this PR

  • fix parsing of object
  • watching the viewMode prop to react on page navigation
  • setting course and module explicitly in basics-section
  • only fetch exams if the courses were found

Type of change (remove all that don't apply)

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added bug Something isn't working vue labels Mar 3, 2021
@tobias-wiese tobias-wiese merged commit d2eee72 into develop Mar 8, 2021
@tobias-wiese tobias-wiese deleted the bugfix/exams branch March 8, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants