Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/502 prompt #886

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Bugfix/502 prompt #886

merged 3 commits into from
Mar 10, 2021

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Mar 10, 2021 •
edited
Loading

Description

Reason for this PR

Changes in this PR

  • Renove form HTML tag to prevent login to be executed twice
  • add HTTP 502 to response handlers
  • add HTTP 502 to toasts

Type of change (remove all that don't apply)

  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

@tobias-wiese tobias-wiese added bug Something isn't working vue labels Mar 10, 2021
@tobias-wiese tobias-wiese mentioned this pull request Mar 10, 2021
Closed
bastihav
bastihav approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@bastihav bastihav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tobias-wiese tobias-wiese merged commit 3474dac into develop Mar 10, 2021
@tobias-wiese tobias-wiese deleted the bugfix/502_prompt branch March 10, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastihav bastihav bastihav approved these changes

Assignees
No one assigned
Labels
bug Something isn't working vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login possible but always fails when auth service is unavailable
2 participants
@tobias-wiese @bastihav