Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add new logo #15

Closed
wants to merge 10 commits into from
Closed

Feature/add new logo #15

wants to merge 10 commits into from

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Sep 15, 2020

  • I replaced the textual placeholders with our new logo
  • I changed the button styling to fit the styling of our main application
  • add title and favicon (see Add Favicon #13)

Note:

@theovier Feel free to merge this PR asa you approve it (I don't think, that we need a develop branch in this repo, do we?)

@tobias-wiese tobias-wiese linked an issue Sep 15, 2020 that may be closed by this pull request
@theovier
Copy link
Collaborator

theovier commented Sep 18, 2020

I'll look into this. However, I'll change the merge request to develop and merge develop into master. I think we should stick with that process even on this project.

Edit: I looked into this. I'm going to create a new PR with your logo changes as it seems you rebased from the wrong branch (for example the Apache license is already online.). Also, there are some changes regarding the title which are not necesssary as the title is set by Laravel. I'll do this at the weekend.

This is partially our fault as the develop branch is behind the master branch which should not happen.

@theovier theovier self-assigned this Sep 18, 2020
@tobias-wiese
Copy link
Contributor Author

Ok, cool :)
I changed the title, because it was set to "laravel" instead of some UC4ish title. Maybe that was a result of the branching problem.

@theovier
Copy link
Collaborator

The title is actually generated by the key/value in your .env file. We adjusted the .env on the sever so it would show UC4, but I assume you didn't touch yours so there is still the default "title=laravel" set. 😄

@theovier theovier mentioned this pull request Sep 20, 2020
@theovier theovier closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Favicon
3 participants