Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new PEP 517 standard with poetry and more "meta" package updates #270

Merged
merged 8 commits into from
Sep 17, 2023

Conversation

Nachtalb
Copy link
Contributor

This pull request migrates the project from using setuptools to Poetry, in line with PEP 517, to improve the project's overall development experience and maintainability. The key enhancements include:

  • Streamlined dependency management, ensuring consistent and deterministic builds across environments.
  • Simplified package publishing, reducing the complexity of deployment.
  • Seamless integration with virtual environments, improving isolation and consistency.

With this migration, the project benefits from a more robust build process, ultimately contributing to higher code quality and a smoother development workflow.

In addition to poetry, I have also updated the remaining "meta" packages (mypy, black, pre-commit etc.):

  • Upgraded pre-commit modules to their latest versions, ensuring adherence to current best practices and coding standards.
  • Performed an update of all code files to ensure they pass the newly configured pre-commit checks, enhancing overall code quality and consistency.
  • Replaced Flake with Ruff, a modern and extensible linting tool, for more accurate and configurable code analysis. This switch allows us to maintain a high level of code quality while also tailoring the linter to our project's specific needs.

Switching to Poetry (the new defacto standard), compliant with PEP 517, for improved dependency handling, deterministic build process, and easier maintainability.
@Nachtalb Nachtalb force-pushed the na/feature-poetry branch 3 times, most recently from f190fec to e5ebdd0 Compare April 25, 2023 20:25
demo.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@nautics889 nautics889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nachtalb
Anyway, checks are passed, also i've tested building project environment with Python 3.7.16 and 3.10.11, everything went well.
+1
Thank you!

Copy link
Contributor

@nautics889 nautics889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nachtalb
Great, thank you!

@upbit upbit merged commit 734a598 into upbit:master Sep 17, 2023
@upbit
Copy link
Owner

upbit commented Sep 17, 2023

Thanks for the contribution!

Sorry for late response, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants