Bump Terraform CLI to v1.5.5 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
requested review from
bobh66,
ytsarev,
negz,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/workspace-inline-aws.yaml" |
| ENV TF_IN_AUTOMATION=1 | ||
| ENV TF_PLUGIN_CACHE_DIR=/tf/plugin-cache | ||
|
|
||
| ADD "bin/${TARGETOS}_${TARGETARCH}/provider" /usr/local/bin/crossplane-terraform-provider | ||
| ADD .gitconfig .gitconfig | ||
|
|
||
| RUN curl -s -L https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip -o terraform.zip \ | ||
| RUN curl -s -L https://github.com/upbound/terraform/releases/download/v${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip -o terraform.zip \ |
There was a problem hiding this comment.
There was a problem hiding this comment.
I would add a comment to that effect before the RUN command.
There was a problem hiding this comment.
Thanks @bobh66, added a comment explaining the situation.
bobh66
requested changes
Aug 28, 2023
- Consume the Terraform CLI from https://github.com/upbound/terraform/releases Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/workspace-inline-aws.yaml" |
bobh66
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR bumps the Terraform CLI version to
v1.5.5and consumes it from https://github.com/upbound/terraform/releases.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Manually tested the provider using Terraform
v1.5.5using the provider exampleexamples/workspace-inline-aws.yaml:Also verified via the the uptest run here.