Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Terraform CLI to v1.5.5 #187

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Bump Terraform CLI to v1.5.5 #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cluster/images/provider-terraform/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@ RUN apk --no-cache add ca-certificates bash git curl
ARG TARGETOS
ARG TARGETARCH

ENV TERRAFORM_VERSION=1.5.2
ENV TERRAFORM_VERSION=1.5.5
ENV TF_IN_AUTOMATION=1
ENV TF_PLUGIN_CACHE_DIR=/tf/plugin-cache

ADD "bin/${TARGETOS}_${TARGETARCH}/provider" /usr/local/bin/crossplane-terraform-provider
ADD .gitconfig .gitconfig

RUN curl -s -L https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip -o terraform.zip \
# Do not change the URL from which the Terraform CLI is downloaded.
# We are using an MPL-2.0 licensed version of the CLI and
# we must make sure that this holds true.
RUN curl -s -L https://github.com/upbound/terraform/releases/download/v${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip -o terraform.zip \
Copy link
Contributor

@jeanduplessis jeanduplessis Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobh66 @ytsarev: Take note that we should not change the location of where we pull the Terraform binary from due to the Terraform BSL change. When the time comes where there is a need for a newer version we should evaluate our options before simply upgrading to a new TF version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment to that effect before the RUN command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bobh66, added a comment explaining the situation.

&& unzip -d /usr/local/bin terraform.zip \
&& rm terraform.zip \
&& chmod +x /usr/local/bin/terraform \
Expand Down
Loading