do not use unsafe_ref_capture #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default output for
Devel::StackTracechanged with version 2.00. There is an option to turn on the old behavior usingunsafe_ref_capture, but the documentation says that this may be unsafe. I suspect that you could in theory be debugging from anywhere, including one of these unsafe constructs, so although the older output is a little more readable, I think not crashing is even better. Here is some more detailed discussion:https://rt.cpan.org/Public/Bug/Display.html?id=99811
This PR also ups the required version of
Devel::StackTrace, so that the old unsafe behavior isn't triggered (and also so that we don't have to have to test two different types of output behavior).