Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added camera_eye virtual frame #19

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Added camera_eye virtual frame #19

merged 5 commits into from
Jul 31, 2024

Conversation

Tordjx
Copy link
Contributor

@Tordjx Tordjx commented Jul 29, 2024

Hi there !
A quick PR to add a camera eye frame which corresponds to the eye of the OAK-D lite camera.
Cheers !

@stephane-caron stephane-caron added the no changelog This PR does not need a changelog update label Jul 29, 2024
Copy link
Member

@stephane-caron stephane-caron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the camera eye location doesn't seem right?

python display_frames.py --only camera_eye --variant camera

image

@Tordjx
Copy link
Contributor Author

Tordjx commented Jul 31, 2024

It appears that when only specifying the inertial part of a link, its frame is displayed as the origin for some reason. A workaround I found was to add a visual box of dimension 0 0 0, and it now looks fine.
Screenshot from 2024-07-31 10-16-42

xacro/torso.xacro Outdated Show resolved Hide resolved
@stephane-caron stephane-caron merged commit ac8a380 into upkie:main Jul 31, 2024
9 checks passed
stephane-caron added a commit that referenced this pull request Jul 31, 2024
stephane-caron added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not need a changelog update
Development

Successfully merging this pull request may close these issues.

2 participants