Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spine-actuation functions #24

Merged
merged 6 commits into from
May 16, 2023
Merged

Conversation

stephane-caron
Copy link
Member

Closes #2

@coveralls
Copy link

coveralls commented May 5, 2023

Pull Request Test Coverage Report for Build 4991451187

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 126 of 130 (96.92%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 82.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
actuation/tests/InterfaceTest.cpp 72 73 98.63%
spine/Spine.cpp 6 7 85.71%
actuation/Interface.cpp 44 46 95.65%
Files with Coverage Reduction New Missed Lines %
spine/Spine.cpp 1 71.33%
Totals Coverage Status
Change from base Build 4862731633: -0.4%
Covered Lines: 1332
Relevant Lines: 1619

💛 - Coveralls

@stephane-caron stephane-caron changed the title Don't re-send previous if no new command Refactor spine-actuation functions May 5, 2023
@stephane-caron stephane-caron marked this pull request as ready for review May 16, 2023 11:53
@stephane-caron stephane-caron merged commit 16a783a into main May 16, 2023
4 checks passed
@stephane-caron stephane-caron deleted the feature/no_resend branch May 16, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Re-sending of previous commands
2 participants