Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Akamai signature generation #220

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Fix Akamai signature generation #220

merged 5 commits into from
Nov 23, 2022

Conversation

dmitry-mukhin
Copy link
Member

Description

Checklist

ivanredbread
ivanredbread approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ivanredbread ivanredbread left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen other libs for such URL construction - this one seems to be good!

@dmitry-mukhin dmitry-mukhin changed the base branch from main to feature/new-v4-base November 18, 2022 13:54
@dmitry-mukhin dmitry-mukhin marked this pull request as ready for review November 18, 2022 13:55
@dmitry-mukhin dmitry-mukhin merged commit 43bf034 into feature/new-v4-base Nov 23, 2022
@homm homm deleted the fix/akamai-fix branch November 24, 2022 14:56
@dmitry-mukhin dmitry-mukhin mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homm homm homm approved these changes

@ivanredbread ivanredbread Awaiting requested review from ivanredbread

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitry-mukhin @homm @ivanredbread