Updated Group constructor to allow URLs

[paul-blundell]

As mentioned in issue #38 the group constructor could not handle URLs. This was creating a problem for multiple file uploads which returns a URL.

I have assumed with this fix that the Group ID will be the last part of the URL. Please correct me if I am wrong.

[dmitry-mukhin]

What will be returned by basename with trailing slash (which is default)?
I think that the better approach is using regexp, like in File's constructor.

[paul-blundell]

Trailing slashes are ignored.

I would strongly recommend native PHP functions over regex, especially when the URL is as simple as this. Of course the choice is yours, I just need something that works and fixes this problem :)

[dmitry-mukhin]

Is it a good idea to let pass "file in group" URL to instantiate a group that contains the file?
I.e. passing ucarecdn.com/:Group-UUID/nth/x/-/:postfixes/filename will get Group with :Group-UUID

[dmitry-mukhin]

@homm, any comments on this?

[homm]

@paul-blundell with regexps we can check exactly format of UUID and throw on wrong links. Moreover, PATHINFO_BASENAME not compliant our CDN rules:

php > print pathinfo("https://ucarecdn.com/c4fed349-2317-4eb3-9e4c-a390081a1e5b~1/meh", PATHINFO_BASENAME);
meh
php > print pathinfo("https://ucarecdn.com/c4fed349-2317-4eb3-9e4c-a390081a1e5b~1/nth/0/", PATHINFO_BASENAME);
0

I would like to see something like this rather than pathinfo().

[paul-blundell]

@homm, makes sense. Like I said I assumed the UUID was the last part, my fault for not checking the documentation fully :)
I shall update this tomorrow with regex.

[homm]

I think it should be like this:
(?P<uuid>[a-z0-9]{8}-(?:[a-z0-9]{4}-){3}[a-z0-9]{12}~(?P<files_qty>\d+))

Where files_qty is part of uuid and also separate integer field (intval($files_qty) is required).

[dmitry-mukhin]

thanks!