SessionTx is hiding errors by returning rollback result #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error that caused the rollback. Rollback error should only be returned if rollback fails
VojtechVitek
requested changes
Dec 5, 2018
session.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
| "reflect" | |||
| "sync" | |||
|
|
|||
| "upper.io/db.v3" | |||
There was a problem hiding this comment.
goimports fixing things for me - fixed.
VojtechVitek
approved these changes
Dec 5, 2018
session.go
Outdated
| @@ -137,7 +137,10 @@ func (s *session) SessionTx(ctx context.Context, fn func(sess Session) error) er | |||
| defer t.Close() | |||
| err := txFn(t) | |||
| if err != nil { | |||
| return t.Rollback() | |||
| if rErr := t.Rollback(); rErr != nil { | |||
| return rErr | |||
There was a problem hiding this comment.
should we return both errors here?
Suggested change
| return rErr | |
| return errors.Wrap(err, rErr.Error()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be returning the error that caused the rollback and only return rollback result if rollback fails