Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor tests #34

wants to merge 2 commits into from

Conversation

xiam
Copy link
Member

@xiam xiam commented Feb 18, 2020 •
edited
Loading

  • move tests under internal/tests
  • use docker-compose to spin up a server and run tests

@xiam xiam requested a review from pkieltyka February 19, 2020 04:43
@xiam
Copy link
Member Author

xiam commented Feb 19, 2020

Hello @pkieltyka,

What do you think about moving tests to a directory?

@pkieltyka
Copy link
Member

Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though

@xiam
Copy link
Member Author

xiam commented Feb 19, 2020 via email •
edited
Loading

@xiam
Copy link
Member Author

xiam commented Feb 19, 2020

I tried this out with https://github.com/upper/bond-example-project and didn't find anything odd with the directory change. I simulated a v0.11.0 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkieltyka pkieltyka Awaiting requested review from pkieltyka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiam @pkieltyka