Transaction support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,16 +8,16 @@ import ( | |||
| ) | |||
|
|
|||
| type Session interface { | |||
| db.Database | |||
| db.Tx | |||
There was a problem hiding this comment.
Same methods as Database, plus Commit() and Rollback().
| func (s *store) Append(item interface{}) (interface{}, error) { | ||
| // Tx returns a copy of the store that runs in the context of the given | ||
| // transaction. | ||
| func (s *store) Tx(tx db.Tx) Store { |
There was a problem hiding this comment.
Returns a new store within the given transaction context.
|
Hello @pkieltyka! This patch adds transaction support. The |
|
this looks great! I think also add some tests to bond_test.go |
| @@ -0,0 +1 @@ | |||
| *.sw? | |||
|
Good point @pkieltyka, I just added them. |
Fixing context issues by passing the session to After* and Before* methods.
… all of them exit with status 0.
| go: | ||
| - 1.4 | ||
| - 1.4.1 | ||
| - 1.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transaction support in bond using a new
NewTransaction()method thats creates abond.Sessionsession that runs within a transaction context. The user can then useCommit()andRollback()methods to save or discard the changes introduces in such session.This may be a small PR but it actually took me a while to simplify the required changes :).
See: #4