-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #3
Conversation
Test code is to be added soon |
Although some code doesn't have the coverage, test code has been added to cover most. This is ready for review, and also I have preliminarily created a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except typo
Co-authored-by: Ryoya Sekino <sryoya0814@gmail.com>
Started the initial implementation by providing 3 commands
Available commands
importer preview FILENAME
: see what's going to happenimporter generate FILENAME
: check all Importer annotations and retrieve the referenced filesimporter purge FILENAME
: remove any data between annotation pairsOther information
github.com/upsidr/homebrew-tap
, which allows the CD setup here to generate the necessary Formula upgrade; I currently get 404 probably because this repo is private, but once made public, we should be able to runbrew install upsidr/tap/importer
testdata
directory contains some files that are used in Go test casesKnown limitations
File reference is done by current directory of where the CLI is run, not relative to the file. This makes it difficult to use, and should be fixed soon.Fixed, the import is done based on relative path from the file with Importer annotationREADME.md
is updated using Importer, but there is no automation setup for it; we should be running Importer against all the key files such asREADME.md
- or perhaps all the files in this repo (the performance is not great at the moment, though).Other considerations to make
importer preview FILENAME
should give the preview of dependency graph and action plans; the current debug print should be done via--dry-run
flag instead