-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust wording and add image #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos and suggestions, the changes are mostly good and this is significantly easier to understand though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo is fixed, and clearer description by extra sentences.
LGTM
just 1 point is left to be discussed
adding a comment below to clarify where to update.
on:
pull_request:
branches: # please update accordingly
- main
- master
this is just IMO and not so important.
WHAT
Better wording and clarify why this is useful
WHY
For better onboarding and introduction