-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow coloring of function nodes based on the script they came from #32
Comments
PR #24 added source script column during coverage testing, so it's available for this purpose. This just needs a way to enable this option. |
PR #40 re-enables this. But again, this is not an option yet surfaced to a user. |
Related to #132. If we are going to add clickable options in the HTML report to adjust the graphic, we should include this as an option as well. |
One of the problems is that I think that viznetwork only lets you color nodes one way at a time. So you can't simultaneously color part of a node with coverage and another part of it with some script identification color. AFAIK I don't think viznetwork lets you toggle options like this. |
I think we might be able to add some custom stuff using the methodology described here. https://deanattali.com/blog/htmlwidgets-tips/#custom-html Some of my ideas around what we can do are:
This seems like a significant change though, and we could probably use some htmlwidgets expertise help. |
This idea is being staged for the next release (v.0.5.0) temporarily. The goal and scope of v0.5.0 is being discussed in #208. |
This should be a byproduct of the
covr::tally_coverage
function in PR #24 . However, I believe these fields are being dropped before populating the nodes table. We should attach them as wellThe text was updated successfully, but these errors were encountered: