-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature durable links #147
Conversation
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mikerniker we also need to update the docusaurus.config.js
file as well
here is what we needs to be update :
({
docs: {
sidebarPath: require.resolve('./sidebars.js'),
// Please change this to your repo.
lastVersion: "current",
versions: {
current: {
label: 'Latest',
},
"2.1.0": {
label: "2.1.0",
},
"2.0.0": {
label: "2.0.0",
},
"1.2.0": {
label: "1.2.0",
},
"1.1.0": {
label: "1.1.0",
},
"1.0.0": {
label: "1.0.0",
},
},
},
just remove the (2.1.0)
from the latest
and also add a new label for the version 2.1.0
ok, thanks @Abhijay007 , I have added the change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really qualified to check the code. The text was existing material. I approve, but others should check as well.
This LGTM, but I currently have a question on this ticket for docusaurus. facebook/docusaurus#9049 It might be the best option to have the latest version redirect to a hardlink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some feedback. We still want a solution were we have a link to the latest version. I think the suggestions I made should resolve that.
fixing broken all-versions link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
ok, thank you! |
Summary of Changes
Used
yarn docusaurus docs:version 2.1.0
to add durable links and changed filepath for .png images inversion-2.1.0/deployment/best-practices.md
to fix image not found error.Related Issue
Closes #67
Checklist
Screenshots (if applicable)
Additional Context
Reviewer(s)
Hi @hexsecs,
I tried tagging the new version with the yarn command. Let me know if I need to make changes. Thank you