pgdriver does not recognize connect_timeout parameter

[jessdwitch]

Passing in connect_timeout when connecting via pgdriver results in:
panic: ERROR: unrecognized configuration parameter "connect_timeout" (SQLSTATE=42704)
However, connect_timeout is listed as a valid parameter here at section "34.1.2. Parameter Key Words".

sqldb := sql.OpenDB(pgdriver.NewConnector(pgdriver.WithDSN("postgres://postgres:@postgresql:5432/testing?connect_timeout=4&sslmode=disable")))
db := bun.NewDB(sqldb, pgdialect.New())
f := dbfixture.New(db, dbfixture.WithRecreateTables())
if err := f.Load(ctx, os.DirFS("../../testdata"), fixtureName); err != nil {
	panic(err)
}

[vmihailenco]

That is a param for libpq client, not a PostgreSQL parameter. The Go/pgdriver analog is https://pkg.go.dev/github.com/uptrace/bun/driver/pgdriver#WithDialTimeout

postgres://postgres:@postgresql:5432/testing?dial_timeout=4s&sslmode=disable

But perhaps we should support connect_timeout as well.

[jessdwitch]

😅 That's slightly embarrassing. That sounds like a quick change I'm up for PR-ing though. Would it be more appropriate to create a new WithConnectTimeout or to modify parseDSN to read connect_timeout as a WithDialTimeout?

[vmihailenco]

or to modify parseDSN to read connect_timeout

This 👍 Perhaps adding something like if d := q.duration("connection_timeout"); d != 0 { here will do, but don't forget to add a test :)