Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reuse tx for relation join #366

Merged
merged 3 commits into from
Dec 19, 2021
Merged

fix: reuse tx for relation join #366

merged 3 commits into from
Dec 19, 2021

Conversation

sbward
Copy link
Contributor

@sbward sbward commented Dec 18, 2021

Fixes #364

  • Minimal change for reusing an existing transaction when joining relations.
  • (Minor) Fixes IDB/IConn interface checking and comments.

@sbward sbward mentioned this pull request Dec 18, 2021
Closed
vmihailenco
vmihailenco reviewed Dec 19, 2021
View reviewed changes
query_select.go Outdated Show resolved Hide resolved
@vmihailenco vmihailenco merged commit 60bdb1a into uptrace:master Dec 19, 2021
@sbward sbward deleted the fix/relation-tx branch December 19, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmihailenco vmihailenco vmihailenco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select with HasMany and ManyToMany does not use current transaction
2 participants
@sbward @vmihailenco