feat(bunotel): add option to enable formatting of queries #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable formatting by default (breaing change) and add bunotel option that enables formatting. Formatting has potential to leak information into the traces as such not formatting the query by default seems like safer option.
|
@vmihailenco would you take a look please? This is breaking change, so if you want the default to stay as it is I will have to invert the logic and have option |
|
@vmihailenco thanks for feedback, updated. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable formatting by default (breaing change)
and add bunotel option that enables formatting.
Formatting has potential to leak information into the traces
as such not formatting the query by default seems like
safer option.
Fixes: #546