Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proyecto roto causa ERROR:null al correr los tests #1841

Closed
fdodino opened this issue Oct 10, 2019 · 4 comments
Closed

Proyecto roto causa ERROR:null al correr los tests #1841

fdodino opened this issue Oct 10, 2019 · 4 comments

Comments

@fdodino
Copy link
Collaborator

fdodino commented Oct 10, 2019

Hoy corrigiendo me saltó un proyecto que hacía romper todo el entorno Wollok: los tests, apareció el Dirty State del Editor, era ingobernable. Refactorizándolo quedó pipí cucú, pero no pude ver qué tenía. Subo para que lo analicemos.

git@github.com:wollok/issue-1841.git
https://github.com/wollok/issue-1841.git

@fdodino
Copy link
Collaborator Author

fdodino commented Oct 12, 2019

El problema está en el fixture, que está reventando, y eso produce que los tests no se inicialicen correctamente. En el fixture estas líneas:

pepe.aprobo(tc1)
matias.aprobo(tc1)
matias.aprobo(tc2)

tiran un error de Wollok, por validaciones del negocio erróneamente definidas!

@fdodino fdodino self-assigned this Oct 12, 2019
fdodino added a commit that referenced this issue Oct 21, 2019
@npasserini
Copy link
Member

npasserini commented Oct 21, 2019 via email

@fdodino
Copy link
Collaborator Author

fdodino commented Oct 21, 2019

Sí, eso es lo que arreglé

@npasserini
Copy link
Member

npasserini commented Oct 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants