Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date toString #964

Closed
asanzo opened this issue Sep 1, 2016 · 6 comments
Closed

Date toString #964

asanzo opened this issue Sep 1, 2016 · 6 comments
Assignees
Milestone

Comments

@asanzo
Copy link

asanzo commented Sep 1, 2016

It'd be nice to have something printed like

un/a Date[1/9/2016]

Instead of today's

un/a Date[]

@fdodino
Copy link
Collaborator

fdodino commented Sep 5, 2016

@asanzo

What about

Date[28/12/2016]

and

Date[28/02/2016]

(withou a/un)

@matifreyre , @flbulgarelli , @npasserini , @tesonep , @javierfernandes ?
I agree that Wollok Date should should day, month & year...

@fdodino fdodino self-assigned this Sep 5, 2016
@fdodino fdodino added this to the Wollok v1.5.1 milestone Sep 5, 2016
@flbulgarelli
Copy link
Contributor

flbulgarelli commented Sep 5, 2016

Hi! Ok for me. Just a suggestion: wollok has i18n, so either:

  • the date format should depend on the locale - please not harcode the dd/mm//yyyy format, or
  • the date should use the international ISO date format - yyyy-mm-dd

@fdodino
Copy link
Collaborator

fdodino commented Sep 5, 2016

Mmmm... I don't personally like it.
But if everybody else does ...

@matifreyre
Copy link
Collaborator

If it's possible to get the date formatted according to the user's OS
locale, that would be nice.

I really like even more any format with the month in characters instead of
numbers (e.g.: 01/Ene/2017) because you can't confuse the day and the month
with each other, but I don't want to add noise to the discussion :-P

On Mon, Sep 5, 2016 at 12:10 PM, Fernando Dodino notifications@github.com
wrote:

Mmmm... I don't personally like it.
But if everybody else does ...


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#964 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ-EZjLMnkARXTgg_2HCW02HUe2sa1L-ks5qnDDNgaJpZM4JzNgG
.

@tesonep
Copy link
Contributor

tesonep commented Sep 5, 2016

I don't like the use of locale strings when entering as a constant. It is a
bad idea, and is not portable between users.

The constants should be written in ISO mode YYYY-mm-dd

Displaying the date is other story, it can be done using the locale, maybe
we can have both representations. I really really prefer using letters for
the month, so the date is undoubtedly written.

On Mon, Sep 5, 2016 at 5:28 PM, Matías Freyre notifications@github.com
wrote:

If it's possible to get the date formatted according to the user's OS
locale, that would be nice.

I really like even more any format with the month in characters instead of
numbers (e.g.: 01/Ene/2017) because you can't confuse the day and the month
with each other, but I don't want to add noise to the discussion :-P

On Mon, Sep 5, 2016 at 12:10 PM, Fernando Dodino <notifications@github.com

wrote:

Mmmm... I don't personally like it.
But if everybody else does ...


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#964
issuecomment-244768275>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ-EZjLMnkARXTgg_
2HCW02HUe2sa1L-ks5qnDDNgaJpZM4JzNgG>

.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#964 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVsf4l2euKnWJrxvaS-uMNBz6ZntnoUks5qnDUfgaJpZM4JzNgG
.

Pablo Tesone.
tesonep@gmail.com

@npasserini
Copy link
Member

On Mon, Sep 5, 2016 at 5:28 PM, Matías Freyre notifications@github.com
wrote:

If it's possible to get the date formatted according to the user's OS
locale, that would be nice.

Maybe it is possible but then you should take that into account in the
tests.

tesonep added a commit that referenced this issue Sep 16, 2016
Adding toString using ISO date format #964 | Test cases now in english
@fdodino fdodino closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants